Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error "websocket.protocol has no attribute OPEN" if websocket connection has exception #13

Open
hhphome opened this issue Apr 28, 2019 · 0 comments

Comments

@hhphome
Copy link

hhphome commented Apr 28, 2019

Since in code, we just connect websocket without checking connect state, so we only met this error when send_commnd.
But in chromewhip/chrome.py:248:
if self._ws.state != websockets.protocol.OPEN: this would raise error since OPEN is in webscokets.protocol.State.
if self._ws.state != websockets.protocol.State.OPEN: should be right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant