Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodiak does not recognise security warnings as resolved #883

Open
Alex-Stagg opened this issue Jan 8, 2024 · 3 comments
Open

Kodiak does not recognise security warnings as resolved #883

Alex-Stagg opened this issue Jan 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Alex-Stagg
Copy link

Hi, We have GitHub security warnings set up on our repos at my company. We're currently trying out Kodiak and finding it very useful, but there seems to be one issue. When a PR gets a warning on it, Kodiak does not seem to recognise when the warning is dismissed, which is stopping us from merging as we have the "Require resolved converations" setting enabled.

If it's of any difference, we're self-hosting Kodiak. Unfortunately I can't any screenshots due to company policy, but I'll try to provide any more information needed

Thanks

@Alex-Stagg Alex-Stagg added the bug Something isn't working label Jan 8, 2024
@chdsbd
Copy link
Owner

chdsbd commented Jan 9, 2024

Are the warnings dismissed by users or by GitHub?

I think maybe Kodiak doesn't get a webhook if GitHub dismisses the comment.

Can you link to a public example security comment or documentation?

@Alex-Stagg
Copy link
Author

We've noticed this issue in both case of users and GH dismissing reviews.

Additionally, as far as I am aware, removing the automerge label and adding it back again (something we've tried) should make Kodiak see that all the conversations are resolved and allow merging to continue. This leads me to believe that Kodiak is having trouble detecting whether these comments are resolved are not.

I can't link to any public example right now, but I'll find something and report back.

@chdsbd
Copy link
Owner

chdsbd commented Jan 12, 2024

@Alex-Stagg Since you're using the self hosted version, maybe your GitHub App isn't configured to send web hooks for pull request comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants