Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with submodules #48

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jun 25, 2021

Previously githubinator couldn't find git data for files inside a submodule.
Now it generates URLs, for the correct repositories.

There's a new test for dir function, but the actual blame URL generation was tested manually on https://github.com/discourse/all-the-plugins and its submodules.

Previously githubinator couldn't find git data for files inside a submodule. Now it generates URLs, for the correct repositories.
package.json Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 8dfbef1 into chdsbd:master Jun 25, 2021
@chdsbd
Copy link
Owner

chdsbd commented Jun 25, 2021

Thanks for the PR! I'll push a new version to the VSCode Marketplace.

@chdsbd
Copy link
Owner

chdsbd commented Jun 25, 2021

I've released a new version to the marketplace. I think it takes some time to propagate.

@CvX CvX deleted the submodules branch June 25, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants