Don't run the tests before the dependencies are actually installed

[azatsarynnyy]

What does this PR do?

Recently, running the test for the che-commands extensions was bound before the dependencies installation phase.
While it works well when building Che-Code assembly from the root of the project, running the dependencies installation solely for the che-commands extension fails. It's because the script depends on the gulp binary which isn't installed yet.
It affects the downstream build.

After merging this PR, the tests for che-commands extensions can be run the same way as for other extensions - by calling yarn test command, e.g:

che-code/code/extensions/html-language-features/server/package.json

Line 30 in 8cf7bbc

"test": "yarn compile && node ./test/index.js"

What issues does this PR fix?

It's needed for https://issues.redhat.com/browse/CRW-3160

How to test this PR?

After running cd code/extensions/che-commands && yarn
the extension's dependencies should be installed successfully, without the error:

$ gulp compile-extension:che-commands
/bin/sh: line 1: gulp: command not found
error Command failed with exit code 127.

[github-actions]

Click here to review and test in web IDE:

[github-actions]

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-227-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-227-dev-amd64

[RomanNikitenko]

After merging this PR, the tests for che-commands extensions can be run the same way as for other extensions - by calling yarn test command

just for my understanding - when do tests for other extensions run?

• on the project build step?
• on the docker build step?
• on the github actions step?
• some another step?

FYI: some of them are already broken, so I guess they are never run:

[azatsarynnyy]

just for my understanding - when do tests for other extensions run?

I suppose the Che-specific extensions were just ported from Che-Theia as it is. I don't remember someone working on any GitHub Action for running the tests. The only way I know is to run yarn test command manually. That's why my suggestion is to automate that with a GitHub Action.
Thanks for the filed issue eclipse-che/che#22213 @RomanNikitenko!

[devstudio-release]

Build 3.7 :: code_3.x/675: Console, Changes, Git Data

[devstudio-release]

Build 3.7 :: sync-to-downstream_3.x/3495: Console, Changes, Git Data

[RomanNikitenko]

@azatsarynnyy
btw, after merging your PR I still have a problem with the gulp dependency:

So, I'm able to provide a change to the extension, but I'm not able to compile only this extension - I have to build all assembly...

[azatsarynnyy]

It fixes the issue of installing the extension's dependencies. In your example, running yarn command finishes successfully now 🎉

I've also never seen the compile scripts (from package.json files) used directly in VS Code 🤷‍♂️
@RomanNikitenko Usually, if I need to compile any single built-in extension of VS Code, I use the compile-extension: gulp task they provide. E.g.: npx gulp compile-extension:che-commands (from the VS Code root, of course):

$ npx gulp compile-extension:che-commands
[11:11:39] Using gulpfile ~/github/che-incubator/che-code/code/gulpfile.js
[11:11:39] Starting 'compile-extension:che-commands'...
[11:11:39] Starting clean-extension-che-commands ...
[11:11:39] Finished clean-extension-che-commands after 5 ms
[11:11:39] Starting compile-extension:che-commands ...
[11:11:39] Starting compilation extensions...
[11:11:41] Finished compilation extensions with 0 errors after 1475 ms
[11:11:41] Finished compile-extension:che-commands after 1737 ms
[11:11:41] Finished 'compile-extension:che-commands' after 1.75 s