-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take into account all certificates located in /public-certs #243
Conversation
Pull Request images published ✨ |
1 similar comment
Pull Request images published ✨ |
Works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request images published ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vitaliy-guliy for working on the fix 👍
It must be the final step to fix the extensions installation in a proxied environment (CRW-3942) 🎉
* fix: take into account all certificates located in /public-certs
What does this PR do?
On each container run
/tmp/che/secret/ca.crt
and for all certificates in/public-certs
/tmp/node-extra-certificates/ca.crt
/tmp/node-extra-certificates/ca.crt
What issues does this PR fix?
eclipse-che/che#22277
How to test this PR?
1. Use prepared sample to test the changes using che-code image, built by github action ( see comments below )
To test:
env | grep NODE_EXTRA_CA_CERTS
to ensureNODE_EXTRA_CA_CERTS
is set and points to a real certificatecat /checode/entrypoint-volume.sh
and check the changes provided by this pull request are present in the file2. The second one:
quay.io
account.che/che-editor.yaml
, specify che-code image3. I build che-code docker image locally and prepared a sample.
To test:
env | grep NODE_EXTRA_CA_CERTS
to ensureNODE_EXTRA_CA_CERTS
is set and points to a real certificate