Switch to canvas xterm.js renderrer, by default
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ |
azatsarynnyy
changed the title
canvas xterm.js renderrer, by defaultcanvas xterm.js renderrer, by default
azatsarynnyy
requested review from
RomanNikitenko,
vitaliy-guliy and
l0rd
as code owners
RomanNikitenko
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switches the default terminal renderer from
webgl(auto) tocanvas.It fixes the problem when the characters are not visible in a terminal while typing.
This issue comes from xterm.js which currently doesn't work correctly with the latest Chrome versions when GPU Acceleration is enabled.
What issues does this PR fix?
https://issues.redhat.com/browse/CRW-4513
How to test this PR?
canvasterminal renderer is set by default: