-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configure pod name for resource monitor #291
Conversation
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Pull Request Dev image published: |
1 similar comment
Pull Request Dev image published: |
Pull Request Che-Code image published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 3.11 :: code_3.x/975: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5222: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3637: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5100: code : 3.x :: Build 56885043 : quay.io/devspaces/code-rhel8:3.11-7 |
Build 3.11 :: code_3.x/975: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5222 triggered |
Build 3.11 :: update-digests_3.x/4856: Console, Changes, Git Data |
What does this PR do?
To get the metrics, resource monitor extension needs to know the pod name, which is provided by
HOSTNAME
environment variable.Sometimes VS Code overwrites the variable with different value ( it looks like it's not VS Code, but someone from dependencies ).
To avoid losing the pod name, it was decided to copy
HOSTNAME
env var toDEVWORKSPACE_POD_NAME
env var before launching the editor, and take the pod name from new variable when necessary.What issues does this PR fix?
https://issues.redhat.com/browse/CRW-3526
How to test this PR?
DEVWORKSPACE_POD_NAME
environment variable is set