Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure pod name for resource monitor #291

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Nov 7, 2023

What does this PR do?

To get the metrics, resource monitor extension needs to know the pod name, which is provided by HOSTNAME environment variable.

Sometimes VS Code overwrites the variable with different value ( it looks like it's not VS Code, but someone from dependencies ).

To avoid losing the pod name, it was decided to copy HOSTNAME env var to DEVWORKSPACE_POD_NAME env var before launching the editor, and take the pod name from new variable when necessary.

What issues does this PR fix?

https://issues.redhat.com/browse/CRW-3526

How to test this PR?

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Nov 7, 2023

Click here to review and test in web IDE: Contribute

@vitaliy-guliy vitaliy-guliy added the made-with-che Changes made with Che-Code label Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-291-dev-amd64

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Nov 7, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-291-dev-amd64

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Nov 7, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-291-dev-amd64

Copy link

github-actions bot commented Nov 7, 2023

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-291-amd64

Copy link

github-actions bot commented Nov 8, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-291-dev-amd64

1 similar comment
Copy link

github-actions bot commented Nov 8, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-291-dev-amd64

Copy link

github-actions bot commented Nov 8, 2023

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-291-amd64

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review November 8, 2023 14:50
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2023 11 09-10_09_35

@vitaliy-guliy vitaliy-guliy merged commit ee372c7 into main Nov 10, 2023
6 checks passed
@vitaliy-guliy vitaliy-guliy deleted the fix-resource-monitor branch November 10, 2023 10:05
@devstudio-release
Copy link

Build 3.11 :: code_3.x/975: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: code_3.x/975: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5222 triggered

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes made with Che-Code
Projects
None yet
4 participants