-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle VS Code state when workspace restart #331
Conversation
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
1 similar comment
Pull Request Dev image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Che-Code image published: |
1 similar comment
Pull Request Che-Code image published: |
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Pull Request Dev image published: |
Pull Request Che-Code image published: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested it on Dev Sandbox.
Everything works perfectly - the workspace is reloaded as expected, with no errors 👍
Thanks @vitaliy-guliy for fixing the problem!
You are lucky you did not face any issues when reloading the workspace. |
What does this PR do?
Improves the behavior when the user asked to restart the workspace with applying local devfile.
Now, after sending a request to stop the workspace, an infinity modal popup is displayed.
The popup is closed when clicking
Reload Now
button or when VS Code lost the connection with backend (we suggested here that the workspace is stopped).Once the popup is closed, the page will be reloaded.
What issues does this PR fix?
eclipse-che/che#22769
How to test this PR?
How to test this PR?
It is better to test it on workspaces.openshift.com as reported in the issue.
To create a workspace use https://github.com/vitaliy-guliy/vscode-test-extension?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/8fbbfafa1de2448acffa01e1386f1a3f/raw/92212202af6d65625a4f13ab40b4e486fd3803d0/editor.yaml