Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve openssl version detection #332

Merged
merged 2 commits into from Mar 11, 2024
Merged

Improve openssl version detection #332

merged 2 commits into from Mar 11, 2024

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Feb 21, 2024 •
edited

What does this PR do?

Improves openssl version detection.
It's related to detection which assembly(ubi8 or ubi9-based) should be used for running che-code in a user's container.

What issues does this PR fix?

eclipse-che/che#22788

How to test this PR?

I tested it for the following images/devfiles, I'm going to do more testing for ubi8-ubi9-based images while the PR is under review.

Devfile registry images

Image Devfile registry link Workspace starts Link to start a workspace
registry.access.redhat.com/ubi8/dotnet-50:5.0-39 .NET 5.0 + click here
registry.access.redhat.com/ubi8/dotnet-60:6.0-45 .NET 6.0 + click here
registry.access.redhat.com/ubi8/dotnet-31:3.1-61 .NET Core 3.1 + click here
registry.access.redhat.com/ubi8/dotnet-60:6.0 Basic .NET + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 Angular + click here
registry.access.redhat.com/ubi9/go-toolset:1.19.13-4.1697647145 Basic Go +
project was not cloned		 click here
registry.access.redhat.com/ubi8/nodejs-16:latest Basic Node.js +
project was not cloned		 click here
registry.access.redhat.com/ubi9/python-39:1-165 Basic Python +
project was not cloned		 click here
registry.access.redhat.com/ubi8/openjdk-17:1.18-2 Basic Quarkus -
Detected unrecoverable event FailedPostStartHook: PostStartHook failed.		 click here
registry.access.redhat.com/ubi9/openjdk-17:1.17-1.1705573248 Basic Spring Boot +
project was not cloned		 click here
registry.access.redhat.com/ubi9/python-39:1-165 Django + click here
registry.access.redhat.com/ubi9/go-toolset:1.19.13-4.1697647145 Go Runtime + click here
quay.io/devfile/composer:2.5.8 Laravel + click here
registry.access.redhat.com/ubi9/openjdk-17:1.17-1.1705573248 Maven Java + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 Next.js + click here
registry.access.redhat.com/ubi8/nodejs-16:latest Node.js Runtime + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 Nuxt.js + click here
icr.io/appcafe/open-liberty-devfile-stack:22.0.0.1-gradle Open Liberty Gradle + click here
icr.io/appcafe/open-liberty-devfile-stack:22.0.0.1 Open Liberty Maven + click here
registry.access.redhat.com/ubi9/python-39:1-165 Python + click here
registry.access.redhat.com/ubi8/openjdk-17:1.18-2 Quarkus Java + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 React + click here
registry.access.redhat.com/ubi9/openjdk-17:1.17-1.1705573248 Spring Boot + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 Svelte + click here
quay.io/devfile/universal-developer-image:ubi8-latest Universal Developer Image + click here
registry.access.redhat.com/ubi8/openjdk-11:1.18-2.1705602259 Vert.x Java + click here
registry.access.redhat.com/ubi8/nodejs-16:1-153 Vue + click here
icr.io/appcafe/websphere-liberty-devfile-stack:22.0.0.1-gradle WebSphere Liberty Gradle + click here
icr.io/appcafe/websphere-liberty-devfile-stack:22.0.0.1 WebSphere Liberty Maven + click here
quay.io/devfile/universal-developer-image:ubi8-latest WildFly + click here
registry.access.redhat.com/ubi8/openjdk-11:1.18-2.1705602259 WildFly Bootable Jar + click here

ubi9-based images:

Image Workspace starts Link to start a workspace
registry.access.redhat.com/ubi9:9.3-1552 + click here
registry.access.redhat.com/ubi9/ubi:9.3-1552 + click here
registry.access.redhat.com/ubi9/ubi-init:9.3-10 + click here
registry.access.redhat.com/ubi9-init:9.3-10 + click here
registry.access.redhat.com/ubi9/ubi-micro:9.3-13 -
openssl is absent		 click here
registry.access.redhat.com/ubi9-micro:9.3-13 -
openssl is absent		 click here
registry.access.redhat.com/ubi9/ubi-minimal:9.3-1552 + click here
registry.access.redhat.com/ubi9-minimal:9.3-1552 + click here
registry.access.redhat.com/ubi9/openssl:9.3-11 -
PostStartHook failed		 click here
registry.access.redhat.com/ubi9/toolbox:9.3-12 + click here
registry.access.redhat.com/ubi9/podman:9.3-10 + click here
registry.access.redhat.com/ubi9/buildah:9.3-10 + click here
registry.access.redhat.com/ubi9/skopeo:9.3-10 + click here
registry.access.redhat.com/ubi9/httpd-24:1-301 + click here
registry.access.redhat.com/ubi9/s2i-core:1-462 + click here
registry.access.redhat.com/ubi9/s2i-base:1-489 + click here
registry.access.redhat.com/ubi9/nginx-120:1-140 + click here
registry.access.redhat.com/ubi9/nginx-122:1-49 + click here
registry.access.redhat.com/ubi9/go-toolset:1.20.10-11 + click here
registry.access.redhat.com/ubi9/perl-532:1-125 + click here
registry.access.redhat.com/ubi9/python-39:1-165 + click here
registry.access.redhat.com/ubi9/python-311:1-45 + click here
registry.access.redhat.com/ubi9/php-80:1-110 + click here
registry.access.redhat.com/ubi9/php-81:1-45 + click here
registry.access.redhat.com/ubi9/ruby-30:1-142 + click here
registry.access.redhat.com/ubi9/ruby-31:1-84 + click here
registry.access.redhat.com/ubi9/nodejs-16:1-147 + click here
registry.access.redhat.com/ubi9/nodejs-18:1-88 + click here
registry.access.redhat.com/ubi9/nodejs-20:1-24 + click here
registry.access.redhat.com/ubi9/nodejs-16-minimal:1-157 + click here
registry.access.redhat.com/ubi9/nodejs-18-minimal:1-93 + click here
registry.access.redhat.com/ubi9/nodejs-20-minimal:1-26 + click here
registry.access.redhat.com/ubi9/openjdk-11:1.17-1.1705602311 + click here
registry.access.redhat.com/ubi9/openjdk-17:1.17-1.1705573248 + click here
registry.access.redhat.com/ubi9/openjdk-21:1.17-2.1705482269 + click here
registry.access.redhat.com/ubi9/openjdk-11-runtime:1.17-1.1705602323 + click here
registry.access.redhat.com/ubi9/openjdk-17-runtime:1.17-1.1705573249 + click here
registry.access.redhat.com/ubi9/openjdk-21-runtime:1.17-2.1705482271 + click here

ubi8-based images:

Image Workspace starts Link to start a workspace
quay.io/devfile/universal-developer-image:ubi8-latest + click here
registry.access.redhat.com/ubi8/pause:8.9-4 -
openssl is absent		 click here
registry.access.redhat.com/ubi8/ubi-micro:8.9-7 -
openssl is absent
error while loading shared libraries: libz.so.1		 click here
registry.access.redhat.com/ubi8-micro:8.9-10 -
openssl is absent
error while loading shared libraries: libz.so.1		 click here
registry.access.redhat.com/ubi8-init:8.9-3 + click here
registry.access.redhat.com/ubi8:8.9-1107.1706791207 + click here
registry.access.redhat.com/ubi8/ubi:8.9-1107.1706791207 + click here
registry.access.redhat.com/ubi8-minimal:8.9-1108.1706795067 + click here
registry.access.redhat.com/ubi8/go-toolset:1.20.10-10 + click here
registry.access.redhat.com/ubi8/dotnet-60:6.0-45 + click here
registry.access.redhat.com/ubi8/dotnet-70:7.0-26 + click here
registry.access.redhat.com/ubi8/dotnet-80:8.0-3 + click here
registry.access.redhat.com/ubi8/dotnet-60-runtime:6.0-45 + click here
registry.access.redhat.com/ubi8/dotnet-70-runtime:7.0-26 + click here
registry.access.redhat.com/ubi8/dotnet-80-runtime:8.0-3 + click here
registry.access.redhat.com/ubi8/skopeo:8.9-3 + click here
registry.access.redhat.com/ubi8/podman:8.9-3 + click here
registry.access.redhat.com/ubi8/openssl:8.9-8 -
error while loading shared libraries: libbrotlidec.so.1		 click here
registry.access.redhat.com/ubi8/toolbox:8.9-8 + click here
registry.access.redhat.com/ubi8/buildah:8.9-3 + click here
registry.access.redhat.com/ubi8/nodejs-16:1-145 + click here
registry.access.redhat.com/ubi8/nodejs-18:1-86 + click here
registry.access.redhat.com/ubi8/nodejs-20:1-22 + click here
registry.access.redhat.com/ubi8/nodejs-16-minimal:1-155 + click here
registry.access.redhat.com/ubi8/nodejs-18-minimal:1-91 + click here
registry.access.redhat.com/ubi8/nodejs-20-minimal:1-24 + click here
registry.access.redhat.com/ubi8/ruby-25:1-239 + click here
registry.access.redhat.com/ubi8/ruby-30:1-140 + click here
registry.access.redhat.com/ubi8/ruby-31:1-82 + click here
registry.access.redhat.com/ubi8/nginx-122:1-47 + click here
registry.access.redhat.com/ubi8/perl-526:1-216 + click here
registry.access.redhat.com/ubi8/perl-532:1-123 + click here
registry.access.redhat.com/ubi8/php-74:1-110 + click here
registry.access.redhat.com/ubi8/php-80:1-108 + click here
registry.access.redhat.com/ubi8/httpd-24:1-299 + click here
registry.access.redhat.com/ubi8/s2i-base:1-486 + click here
registry.access.redhat.com/ubi8/s2i-core:1-459 + click here
registry.access.redhat.com/ubi8/python-311:1-43 + click here
registry.access.redhat.com/ubi8/python-27:2.7-231 + click here
registry.access.redhat.com/ubi8/python-36:1-228 + click here
registry.access.redhat.com/ubi8/python-39:1-163 + click here
registry.access.redhat.com/ubi8/openjdk-8:1.18-2.1705572794 + click here
registry.access.redhat.com/ubi8/openjdk-11:1.18-2.1705602259 + click here
registry.access.redhat.com/ubi8/openjdk-17:1.18-2.1705573234 + click here
registry.access.redhat.com/ubi8/openjdk-21:1.18-3.1705519633 + click here
registry.access.redhat.com/ubi8/openjdk-8-runtime:1.18-2.1705572797 + click here
registry.access.redhat.com/ubi8/openjdk-11-runtime:1.18-2.1705602291 + click here
registry.access.redhat.com/ubi8/openjdk-17-runtime:1.18-2.1705573231 + click here
registry.access.redhat.com/ubi8/openjdk-21-runtime:1.18-2.1705519635 + click here

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited

Click here to review and test in web IDE: Contribute

@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-332-dev-amd64

@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-332-amd64

@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-332-dev-amd64

@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-332-amd64

@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-332-dev-amd64

@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-332-amd64

@RomanNikitenko
fix: Use ubi9-based assembly when openssl version was not determined
bdecd59 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
chore: Check libssl version when user's container doesn't have neithe…
1df915d 
…r openssl nor rpm

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-332-dev-amd64

@RomanNikitenko RomanNikitenko changed the title fix: Use ubi9-based assembly when openssl version was not determined Improve openssl version detection Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-332-amd64

@RomanNikitenko RomanNikitenko marked this pull request as ready for review March 5, 2024 12:15
@RomanNikitenko
Copy link
Contributor Author

I'm going to do more testing for ubi8-ubi9-based images while the PR is under review.

ibuziuk
ibuziuk reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanNikitenko are you ok to merge this PR in main only without backporting to 7.82.x for 3.12?

@RomanNikitenko RomanNikitenko mentioned this pull request Mar 7, 2024
Open
@RomanNikitenko
Copy link
Contributor Author

@RomanNikitenko are you ok to merge this PR in main only without backporting to 7.82.x for 3.12?

it's ok for me to merge the PR in the main only
at the same time - I've tested a lot of images for the current PR - I think it makes sense to test ubi8 and ubi9-based images for 3.12.

@RomanNikitenko RomanNikitenko merged commit 405928e into main Mar 11, 2024
7 checks passed
@RomanNikitenko RomanNikitenko deleted the openssl-detection branch March 11, 2024 19:13
@monaka monaka mentioned this pull request Mar 21, 2024
Open
@RomanNikitenko RomanNikitenko mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy azatsarynnyy is a code owner

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RomanNikitenko @ibuziuk