Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove travis scripts and add github actions for release purpose #1033

Merged
merged 10 commits into from
Dec 15, 2020
Merged

feat: Remove travis scripts and add github actions for release purpose #1033

merged 10 commits into from
Dec 15, 2020

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Dec 14, 2020 •
edited
Loading

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

Remove travis scripts and add github actions to release stable and next versions of chectl.

Refference issue:eclipse-che/che#18260

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@flacatus
feat: Remove travis scripts and add github actions
ac3bd9a 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

flacatus commented Dec 14, 2020 •
edited
Loading

I'm testing this changes agains my fork and releases looks identical: https://github.com/flacatus/chectl
Next release: https://github.com/flacatus/chectl/releases/tag/20201214203352
Stable release: https://github.com/flacatus/chectl/releases/tag/20201214200047

@tolusha tolusha mentioned this pull request Dec 14, 2020
Closed
56 tasks
@flacatus
fix:_Add travis file
475e042 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
feat: change workflow name and add common release push for stable and…
dfbca85 
… enxt

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
feat: Change node version and ubuntu version
4a3ebd7 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Add unit tests to PRs
0c7d8ab 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
fixes
d971606 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
fixes
34c42e6 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
fix
d7d77aa 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@nickboldt nickboldt self-requested a review December 14, 2020 20:59
nickboldt
nickboldt approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I didn't run this. Deferring to others for final say. +0.1

@flacatus
Copy link
Collaborator Author

@nickboldt https://github.com/flacatus/chectl/releases
You can try in my fork

benoitf
benoitf reviewed Dec 14, 2020
View reviewed changes
.github/workflows/draft-release.yml Outdated
run: |
# since we're using Flavius' token below to generate PRs, should also make tags/branches/commits by same owner
# see https://github.com/che-incubator/chectl/settings/secrets/actions for the token used
git config --global user.name "Flavius Lacatusu"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be author that perform the release ?

@flacatus
fix: remove unnecessary thinkgs and rename the workflows
6d1031e 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus flacatus changed the title feat: Remove travis scripts and add github actions feat: Remove travis scripts and add github actions for release purpose Dec 14, 2020
@flacatus
Fixes
6da3f11 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
benoitf
benoitf approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, flacatus, nickboldt, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus merged commit 4904853 into master Dec 15, 2020
flacatus added a commit that referenced this pull request Dec 15, 2020
@flacatus
feat: Remove travis scripts and add github actions for release purpose …
0df428d 
…#1033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@benoitf benoitf benoitf approved these changes

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@l0rd l0rd Awaiting requested review from l0rd

@mmorhun mmorhun Awaiting requested review from mmorhun

Assignees

@nickboldt nickboldt

@benoitf benoitf

@tolusha tolusha

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flacatus @openshift-ci-robot @nickboldt @benoitf @tolusha