fix: [Helm] Select ClusterIssuer by label #1037
Conversation
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
tolusha,
sleshchenko,
AndrienkoAleksandr and
flacatus
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
src/constants.ts
Outdated
| @@ -8,6 +8,9 @@ | |||
| * SPDX-License-Identifier: EPL-2.0 | |||
| **********************************************************************/ | |||
|
|
|||
| // labels | |||
| export const CHE_RELATED_COMPONENT_LABEL = 'app=che' | |||
There was a problem hiding this comment.
Pls remove label usage.
If am not sure about appropriate label
There was a problem hiding this comment.
I would like to keep the label. It gives better user experience, imo. But I agree, that the label itself should be changed
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
| const clusterIssuersList: {items?: any[]} = res.body | ||
|
|
||
| return clusterIssuersList.items || [] |
There was a problem hiding this comment.
| const clusterIssuersList: {items?: any[]} = res.body | |
| return clusterIssuersList.items || [] | |
| return res.body.items || [] |
There was a problem hiding this comment.
We imply items field at by const clusterIssuersList: {items?: any[]} = res.body. I think it should be kept.
tolusha
changed the title
| @@ -65,6 +67,8 @@ export class CertManagerTasks { | |||
| throw new Error('Cert Manager should be deployed before.') | |||
| } | |||
|
|
|||
| ctx.certManagerK8sApiVersion = await this.kubeHelper.getCertManagerK8sApiVersion() | |||
There was a problem hiding this comment.
We should move this to Set up Eclipse Che certificates issuer task due to enabled: ctx => ctx.certManagerInstalled,
There was a problem hiding this comment.
Cert Manager will be present at that step. The check is done just for case.
|
@mmorhun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Makes chectl to select Cert-Managers's ClusterIssuer by label instead of creating own one.
The new behaviour:
What issues does this PR fix or reference?
eclipse-che/che#18450
How to test this PR?
app=chelabelPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.