Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove not actual openshift oAuth auto detection. #1038

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 17, 2020

What does this PR do?

Remove not actual openshift oAuth auto detection.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1361

How to test this PR?

You need to install Eclipse Che on the openshfit 4 with no identity providers. Message about OpenShift OAuth is turned off shouldn't appear.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title Remove not actual openshift oAuth auto detection. fix: Remove not actual openshift oAuth auto detection. Dec 17, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Dec 17, 2020
@AndrienkoAleksandr AndrienkoAleksandr merged commit 06243fa into master Dec 21, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the removeOAuthAutoDetectCode branch December 21, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants