Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Eclipse Che deploy / update flow #1082

Merged
merged 21 commits into from
Feb 9, 2021
Merged

Improve Eclipse Che deploy / update flow #1082

merged 21 commits into from
Feb 9, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Feb 2, 2021

What does this PR do?

This PR contains several changes:

  • Now chectl is able to deploy embedded (the same as cli) version of Che and all (with some limitations) previous versions.
  • Added version flag to server:deploy command, that downloads templates for older versions. For future versions, update of chectl is required (so far the limitation is UX not technical).
  • Added warning message for each command if newer chectl is available. For server:deploy and server:update commands interactive prompt is added.
  • Deleted outdated installer minishift-addon.

What issues does this PR fix or reference?

eclipse-che/che#18022

How to test this PR?

  • Deploy Eclipse Che using different installers.
  • Use --version flag with different installers.
  • Deploy Che using external templates.
  • Update Che using operator and OLM installers.
  • Change chectl version to see update warnings.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
…can be deployed with chectl

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@@ -479,12 +482,18 @@ OPTIONS
-t, --templates=templates
Path to the templates folder

-v, --version=version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's odd because I might expect that -v or --version will display the current version of the cli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag is used as an argument for server:deploy command, so it will not collide with -v flag of chectl itself.

src/api/kube.ts Outdated Show resolved Hide resolved
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun merged commit 57d1e1f into master Feb 9, 2021
@mmorhun mmorhun deleted the che-18022 branch February 9, 2021 15:49
@che-bot che-bot added this to the 7.26 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants