Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to override workspace name when creating a workspace from a devfile #166

Merged
merged 3 commits into from Jun 14, 2019

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Jun 13, 2019

Each time a developer creates a workpace from the same devfile, if the workspace name already exist, che would suffix it with an underscore char + incremental number.
This PR provides the ability to customize this name in the case user would like to name its workspace differently. For instance name could containsindication about the task/issue or anything else.

Previously, without the option:

chectl workspace:start --devfile=devfile.yaml
  ✔ Retrieving Che Server URL...http://che-che.192.168.39.216.nip.io
  ✔ Verify if Che server is running
  ✔ Create workspace from Devfile devfile.yaml

Workspace IDE URL:
http://che-che.192.168.39.216.nip.io/dashboard/#/ide/che/chectl_3

Now with the option --name=

chectl workspace:start --devfile=devfile.yaml --name=chectl-fix-component-name
  ✔ Retrieving Che Server URL...http://che-che.192.168.39.216.nip.io
  ✔ Verify if Che server is running
  ✔ Create workspace from Devfile devfile.yaml

Workspace IDE URL:
http://che-che.192.168.39.216.nip.io/dashboard/#/ide/che/chectl-fix-component-name

…vfile

Signed-off-by: Sun Tan <sutan@redhat.com>
@sunix sunix requested a review from l0rd June 13, 2019 13:23
@benoitf
Copy link
Collaborator

benoitf commented Jun 13, 2019

@sunix please fix the build before merging

Signed-off-by: Sun Tan <sutan@redhat.com>
Signed-off-by: Sun Tan <sutan@redhat.com>
@sunix sunix merged commit 8269d47 into master Jun 14, 2019
@sunix sunix deleted the start-devfile-with-wsname branch June 16, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants