Make our types definitions typescript modules #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
akurinnoy
approved these changes
Oct 8, 2021
| @@ -21,7 +23,7 @@ export interface V1CertificateSpec { | |||
| secretName: string | |||
| issuerRef: V1CertificateSpecIssuerReference | |||
| commonName: string | |||
| dnsNames: List<string> | |||
| dnsNames: string[] | |||
There was a problem hiding this comment.
I'm not sure where the List comes from and if it can be replaced with Array. I suppose it should be OK as far as the build doesn't fail.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
tolusha
approved these changes
Oct 8, 2021
AndrienkoAleksandr
approved these changes
Oct 8, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
As
*.d.tsfiles are used to defines types for*.jsfiles, our types definitions should be regular typescript modules (files).Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A refactoring
How to test this PR?
N/A refactoring
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.