-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update templates to enable nginx for Docker Desktop #1882
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha I enabled kubernetes on Docker Desktop 4.3.0 (71786) mac os Monterey, set up more RAM and tested this pr. Installation process is working: › Installer type is set to: 'operator'
› Current Kubernetes context: 'docker-desktop'
✔ Verify Kubernetes API...OK
✔ 👀 Looking for an already existing Eclipse Che instance
✔ Verify if Eclipse Che is deployed into namespace "eclipse-che"...it is not
✔ ✈️ Docker Desktop preflight checklist
✔ Verify if kubectl is installed
✔ Verify if kubectl context is Docker Desktop: Found docker-desktop.
✔ Verify remote kubernetes status...done.
✔ Check Kubernetes version: Found v1.22.4.
✔ Verify if nginx ingress is installed
↓ Installing nginx ingress [skipped]
→ Ngninx ingress is already setup.
✔ Verify domain is set... auto-assigning domain to 192.168.0.186.nip.io....set to 192.168.0.186.nip.io.
✔ Following Eclipse Che logs
✔ Start following Operator logs...done
✔ Start following Eclipse Che Server logs...done
✔ Start following PostgreSQL logs...done
✔ Start following Keycloak logs...done
✔ Start following Plug-in Registry logs...done
✔ Start following Devfile Registry logs...done
✔ Start following Eclipse Che Dashboard logs...done
✔ Start following namespace events...done
✔ Create Namespace eclipse-che...[Exists]
✔ 🏃 Running the Eclipse Che operator
✔ Create ServiceAccount che-operator in namespace eclipse-che...done.
✔ Read Roles and Bindings...done.
✔ Creating Roles and Bindings...done.
✔ Create CRD checlusters.org.eclipse.che...done.
✔ Create backup and restore CRDs...done.
✔ Waiting 5 seconds for the new Kubernetes resources to get flushed...done.
✔ Create deployment che-operator in namespace eclipse-che...done.
✔ Operator pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Prepare Eclipse Che cluster CR...Done.
✔ Create the Custom Resource of type checlusters.org.eclipse.che in the namespace eclipse-che...done.
✔ ✅ Post installation checklist
✔ PostgreSQL pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Keycloak pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Devfile Registry pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Plug-in Registry pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Eclipse Che Dashboard pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Eclipse Che Server pod bootstrap
✔ Scheduling...done
✔ Downloading images...done
✔ Starting...done
✔ Eclipse Che status check...done
✔ Retrieving Che self-signed CA certificate...OK
✔ Prepare post installation output...done
✔ Show important messages
✔ Eclipse Che 7.41.0-SNAPSHOT has been successfully deployed.
✔ Documentation : https://www.eclipse.org/che/docs/
✔ -------------------------------------------------------------------------------
✔ Users Dashboard : https://che-eclipse-che.192.168.0.186.nip.io
✔ Admin user login : "admin:admin". NOTE: must change after first login.
✔ -------------------------------------------------------------------------------
✔ Plug-in Registry : https://plugin-registry-eclipse-che.192.168.0.186.nip.io/v3/
✔ Devfile Registry : https://devfile-registry-eclipse-che.192.168.0.186.nip.io/
✔ -------------------------------------------------------------------------------
✔ [ACTION REQUIRED] Please add Che self-signed CA certificate into your browser: /var/folders/0r/5kq8sbvs327grtqxjndc2zn00000gn/T/cheCA.crt.
Documentation how to add a CA certificate into a browser: https://www.eclipse.org/che/docs/che-7/end-user-guide/importing-certificates-to-browsers/
Command server:deploy has completed successfully in 04:49. But, when I opened che url: This site can’t be reached Do I need some extra steps to enable ingress ? |
Ngninx has been already enabled. |
@tolusha I tested this pr under the Windows 10 and docker Desktop 4.3.0 with wsl2. Works fine. I installed Eclipse Che, created and started workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, controller-v1.1.0 definetly doesn't work on Mac. I found that version controller-v1.0.0 works fine on Mac, but I didn't tested it on the Windows yet.
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Dowgraded to v1.0.0 |
Codecov Report
@@ Coverage Diff @@
## main #1882 +/- ##
=======================================
Coverage 10.38% 10.38%
=======================================
Files 63 63
Lines 6962 6960 -2
Branches 1168 1168
=======================================
Hits 723 723
+ Misses 6239 6237 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I finally got it. For testing I used "Reset Kubernetes cluster", but I didn't do one thing: after reset k8s api I have to quite from Docker Desktop program and start it again. Only after this manipulation load balancer works like expected and I can repeat installation on the clean flow... Or like alternative I have to reinstally Docker Desktop completely.... So revert, please, version 1.1.0 - it works for Mac os Monterey and Docker Desktop 4.3.0 and for Windows 10 too, sorry for delay.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
New changes are detected. LGTM label has been removed. |
@AndrienkoAleksandr: I tried to create after resetting in my local docker instance. it is failing. Below is the log`-------------------------------------------------------------------------------
|
I fixed the issue, by running this command, kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.1.0/deploy/static/mandatory.yaml |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Update templates to enable nginx for Docker Desktop
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20901
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.