ci: Use NodeJS 16

[tolusha]

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

• Use NodeJS 16
• Unify PRs checks

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#21075

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[benoitf]

probably

chectl/package.json

Line 54 in 1f6cc71

"@types/node": "^12",

and

chectl/package.json

Line 76 in 1f6cc71

"node": ">=12.0.0"

could be bumped as well

[benoitf]

approving overall changes, but it seems there are still compilation failures

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[tolusha]

/retest

[benoitf]

/retest

[benoitf]

it seems openshift ci is failing due to

[1/5] Validating package.json...
error chectl@0.0.2: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "12.22.9"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

[tolusha]

I've changed it
https://github.com/che-incubator/chectl/pull/1986/files#diff-6704820b78e3aea8581dff31b66a527b85fc1e2635264f0c6961acb16529ff24
It must be another reason

[tolusha]

/retest

[tolusha]

Fixed by updating NodeJs version in the main branch
#1988