feat: Allows to override default values #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
tolusha
changed the title
sleshchenko
approved these changes
Feb 13, 2020
README.md
Outdated
| @@ -279,6 +279,10 @@ OPTIONS | |||
| -t, --templates=templates | |||
| [default: templates] Path to the templates folder | |||
|
|
|||
| --che-operator-cr-patch=che-operator-cr-patch | |||
There was a problem hiding this comment.
well, it's actually checluster-cr... Maybe it makes sense to name it like this then?
README.md
Outdated
| @@ -279,6 +279,10 @@ OPTIONS | |||
| -t, --templates=templates | |||
| [default: templates] Path to the templates folder | |||
|
|
|||
| --che-operator-cr-patch=che-operator-cr-patch | |||
There was a problem hiding this comment.
Suggested change
| --che-operator-cr-patch=che-operator-cr-patch | |
| --che-operator-cr-patch=che-operator-cr-patch.yaml |
README.md
Outdated
| @@ -279,6 +279,10 @@ OPTIONS | |||
| -t, --templates=templates | |||
| [default: templates] Path to the templates folder | |||
|
|
|||
| --che-operator-cr-patch=che-operator-cr-patch | |||
| Path to a yaml file that overrides the default value a CheCluster used by the operator. This parameter is used only | |||
There was a problem hiding this comment.
Suggested change
| Path to a yaml file that overrides the default value a CheCluster used by the operator. This parameter is used only | |
| Path to a yaml file that overrides the default values in CheCluster CR used by the operator. This parameter is used only |
This was referenced Feb 14, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Allows to override default values of custom resources by providing a patch file.
patch.yaml
What issues does this PR fix or reference?
eclipse-che/che#15684