Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make templates being resolved either locally or from embedded location #51

Merged
merged 2 commits into from Mar 7, 2019

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 7, 2019

Fix README being changed every time

so if in current directory, there is a templates folder, use it
fallback to embedded location

Change-Id: I841f3f88b39e712f0c17a217624fa255369d80e4
Signed-off-by: Florent Benoit fbenoit@redhat.com

Fix README change

Change-Id: I841f3f88b39e712f0c17a217624fa255369d80e4
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Collaborator Author

benoitf commented Mar 7, 2019

ci is failing due to jestjs/jest#8069

Change-Id: I64551cc87d714389e9d912341022ce2c51dd810c
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Collaborator Author

benoitf commented Mar 7, 2019

fixing nodejs version to a LTS release as well

Copy link
Collaborator

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@benoitf benoitf merged commit d63cb2d into master Mar 7, 2019
@benoitf benoitf deleted the fix-templates branch March 7, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants