fix: Fix starting multiple che instances in the same cluster #598
Conversation
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
changed the title
|
I still want to try better handle code part with clean up CRD. Currently I removed clean up CRD on remove Che, because CRD has global scope. We can not create CRD in namespace scope kubernetes/kubernetes#65551 per Che installation. When we remove CRD to clean one Che installation we actually remove CRD for all Che instances and breaks all installation in the same cluster... |
AndrienkoAleksandr
requested review from
tolusha,
sleshchenko,
davidfestal and
mmorhun
| @@ -376,15 +382,6 @@ export class OperatorTasks { | |||
| } | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I understand that we should not delete the CRD when it might still be used by other installations.
OTOH for now, on the chectl server:start, the CRD is only created if it didn't exist as shown here.
That means that deleting a Che server with a chectl version and reinstalling with a new version of chectl will not update the CRD anymore.
That's a hard-to-solve question here, since we can manage only one version of the CRD.
That's a typical case where OLM-based installation has a real value, because the logic of CRD update is managed by OLM itself.
There was a problem hiding this comment.
@davidfestal
If we are not going to delete CRD file, I would suggest to update it every time we install che using checlt
There was a problem hiding this comment.
It allows to keep CRD up to date
What does this PR do?
Provide unique clusterrole and clusterrole binding per che instance in the same cluster. Use namespace suffix for this purpose:
${che-role-name}-namespaceand${che-rolebinding-name}-namespaceWhat issues does this PR fix or reference?
eclipse-che/che#15345
Mostly for https://issues.redhat.com/browse/CRW-505?focusedCommentId=13816159&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel