feat: Add domain checks for Kubernetes family infrastructures #615
Conversation
mmorhun
changed the title
mmorhun
force-pushed
the
add-domain-ping-check
branch
from
120238f
to
90380ee
Compare
| export function getPingClusterTask(flags: any): Listr.ListrTask { | ||
| return { | ||
| title: 'Check if cluster accessible', | ||
| skip: () => flags['skip-cluster-check'], |
There was a problem hiding this comment.
No, because I want to show warning
| } | ||
|
|
||
| if (!await checkServer(domain, 80) || !await checkServer(domain, 443)) { | ||
| throw new Error(`Cannot reach cluster "${domain}". To skip this check add "--skip-cluster-check" flag.`) |
There was a problem hiding this comment.
neither ${domain}:80 nor ${domain}:443
There was a problem hiding this comment.
Instead of
Cannot reach cluster "${domain}". To skip this check add "--skip-cluster-check" flag.
it is better to log
Cannot reach neither '${domain}:80' nor '${domain}:443'. It means the incorrect domain is used. Please, set the correct domain or bypass the check by using '--skip-domain-check' flag.
There was a problem hiding this comment.
I do not think it is a good idea to print domain twice. I would like to avoid it.
mmorhun
force-pushed
the
add-domain-ping-check
branch
from
90380ee
to
5a77845
Compare
src/commands/server/start.ts
Outdated
| @@ -140,6 +140,10 @@ export default class Start extends Command { | |||
| 'skip-version-check': flags.boolean({ | |||
| description: 'Skip minimal versions check.', | |||
| default: false | |||
| }), | |||
| 'skip-cluster-check': flags.boolean({ | |||
There was a problem hiding this comment.
--skip-cluster-availability-check as we agreed
| } | ||
|
|
||
| if (!await checkServer(domain, 80) || !await checkServer(domain, 443)) { | ||
| throw new Error(`Cannot reach cluster "${domain}". To skip this check add "--skip-cluster-check" flag.`) |
There was a problem hiding this comment.
Instead of
Cannot reach cluster "${domain}". To skip this check add "--skip-cluster-check" flag.
it is better to log
Cannot reach neither '${domain}:80' nor '${domain}:443'. It means the incorrect domain is used. Please, set the correct domain or bypass the check by using '--skip-domain-check' flag.
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
force-pushed
the
add-domain-ping-check
branch
from
5a77845
to
fcffd86
Compare
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Adds check whether Kubernetes cluster is reachable when installing Che.
The check could be disabled by
--skip-cluster-checkflag.What issues does this PR fix or reference?
#613