Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to duplicate some messages at the end of chectl output #619

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Apr 3, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Adds functionality to print logs duplicates at the end of chectl output to avoid missing of the important messages by users.

Example with importing CA certificate:
Screenshot from 2020-04-03 13-49-02

What issues does this PR fix or reference?

eclipse-che/che#16277

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun requested a review from l0rd as a code owner April 3, 2020 10:55
@mmorhun mmorhun changed the title Add ability to duplicate some messages at the end of chectl output feat: Add ability to duplicate some messages at the end of chectl output Apr 3, 2020
@mmorhun mmorhun self-assigned this Apr 3, 2020
Copy link
Contributor

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe along with messages on Dashboard side, it will help to avoid created issues caused of CA is not imported.

@mmorhun mmorhun merged commit f21c09b into master Apr 3, 2020
@mmorhun mmorhun deleted the che-16277 branch April 3, 2020 12:45
@tolusha tolusha mentioned this pull request Apr 3, 2020
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants