feat: Print the current context when chectl is run #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
tolusha
changed the title
43 tasks
tolusha
changed the title
tolusha
changed the title
AndrienkoAleksandr
approved these changes
Apr 16, 2020
|
[test] |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
mmorhun
reviewed
Apr 16, 2020
50 tasks
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
|
After digging into the code I figured out that if (process.env.KUBECONFIG && process.env.KUBECONFIG.length > 0) {
const files = process.env.KUBECONFIG.split(path.delimiter);
this.loadFromFile(files[0]);
for (let i = 1; i < files.length; i++) {
const kc = new KubeConfig();
kc.loadFromFile(files[i]);
this.mergeConfig(kc);
}
return;
}So, I've decided just to print the current context |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
changed the title
|
[test] |
mmorhun
reviewed
Apr 16, 2020
| kc = new KubeConfig() | ||
| portForwardHelper = new PortForward(this.kc, true) | ||
| logHelper = new Log(this.kc) | ||
| public static readonly KUBE_CONFIG = KubeHelper.initializeKubeConfig() |
There was a problem hiding this comment.
I am not keen on the idea to make kubeconfig static.
There was a problem hiding this comment.
KubeHelper is helper class which is used to communicate with Kubernetes API. By making kubeconfig static you basically make whole class static, so it becomes more a namespace than a class... It is my vision...
|
[test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Prints the current context when chectl is run
What issues does this PR fix or reference?
eclipse-che/che#15741