Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to skip health check #685

Merged
merged 2 commits into from
May 5, 2020
Merged

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented May 5, 2020

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What does this PR do?

Add --skip-kubernetes-health-check flag to bypass k8s health check.

What issues does this PR fix or reference?

eclipse-che/che#15331

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request May 5, 2020
50 tasks
@tolusha tolusha changed the title Add flag to skip health check feat: Add flag to skip health check May 5, 2020
Copy link
Contributor

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to add a message to a place where we fail k8s health check:

if you're sure that your Kubernetes cluster is healthy - you may skip this check with  --skip-kubernetes-health-check flag

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented May 5, 2020

[test]

@tolusha tolusha merged commit 9061410 into master May 5, 2020
@tolusha tolusha deleted the ab/skiphealthcheckflag branch May 5, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants