fix: Detect olm installer type for server:update command #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
tolusha
changed the title
mmorhun
approved these changes
May 14, 2020
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
56 tasks
| async setDefaultInstaller(flags: any): Promise<void> { | ||
| const cheVersion = DEFAULT_CHE_OPERATOR_IMAGE.split(':')[1] | ||
| const kubeHelper = new KubeHelper(flags) | ||
| if (flags.platform === 'openshift' && await kubeHelper.isOpenShift4() && cheVersion !== 'nightly' && cheVersion !== 'latest') { |
There was a problem hiding this comment.
what about crc ?
There was a problem hiding this comment.
It is just for openshift
AndrienkoAleksandr
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Check if subscription exists and automatically set installer type to
olmif it wasn't specified.What issues does this PR fix or reference?
eclipse-che/che#16861