Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup OpenShift OAuth by default on OpenShift infrastructure #809

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Aug 10, 2020

What does this PR do?

  • removes os-oauth flag (OpenShift OAuth is turned on by default)

More details in https://www.eclipse.org/lists/che-dev/msg03867.html

What issues does this PR fix or reference?

eclipse-che/che#17488

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested a review from l0rd as a code owner August 10, 2020 07:16
@tolusha tolusha changed the title Setup OpenShift OAuth by default on OpenShift infrastructure feat: Setup OpenShift OAuth by default on OpenShift infrastructure Aug 10, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun assigned tolusha and unassigned mmorhun Aug 10, 2020
@tolusha
Copy link
Collaborator Author

tolusha commented Aug 10, 2020

[test]

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit aaf3582 into master Aug 10, 2020
@tolusha tolusha deleted the setosoauthtrue branch August 10, 2020 11:04
@che-bot che-bot added this to the 7.18 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants