Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't remove CRD if another deployments found #828

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Aug 27, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Deletes CRD only if there no another checluster CR

What issues does this PR fix or reference?

eclipse-che/che#16000

Existed Eclipse Che operator: quay.io/eclipse/che-operator:7.18.0.
New Eclipse Che operator    : che-operator:latest.
 ›   Warning: This command updates Eclipse Che to 7.18.0 version, but custom operator image is specified.
 ›   Warning: Make sure that the new version of the Eclipse Che is corresponding to the version of the tool you use.
 ›   Warning: Consider using 'chectl update [stable|next]' to update to the latest version of chectl.
If you want to continue - press Y:

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title Don't remove CRD if another deployments found fix: Don't remove CRD if another deployments found Aug 27, 2020
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
task: async (_ctx: any, task: any) => {
const checlusters = await kh.getAllCheCluster()
if (checlusters.length > 0) {
task.title = await `${task.title}...Another Eclipse Che deployment found.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: ${task.title} ... Skip: another Eclipse Che deployment found

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit 90f4700 into master Aug 28, 2020
@tolusha tolusha deleted the fixdeletecrd branch August 28, 2020 06:50
@che-bot che-bot added this to the 7.19 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants