Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix chectl logs before che pods start #836

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix: Fix chectl logs before che pods start #836

merged 2 commits into from
Aug 31, 2020

Conversation

flacatus
Copy link
Collaborator

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

Sometimes chectl fails before Che pods start and that means there are not any logs.
This PR check if directory logs are empty and print a message.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-859

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

image

@dmytro-ndp
Copy link
Contributor

IMHO "Installation failed, check logs in '${ctx.directory}'`)" message should be shorten if there are no logs available.

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

@dmytro-ndp: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmytro-ndp, flacatus, tolusha
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus merged commit 9838d2b into che-incubator:master Aug 31, 2020
@che-bot che-bot added this to the 7.19 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants