Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rework server:delete to remove consoleLinks, namespace or openshift oauthAuthorizations #842

Merged
merged 6 commits into from
Sep 4, 2020
Merged

feat: Rework server:delete to remove consoleLinks, namespace or openshift oauthAuthorizations #842

merged 6 commits into from
Sep 4, 2020

Conversation

flacatus
Copy link
Collaborator

@flacatus flacatus commented Sep 3, 2020 •
edited by tolusha
Loading

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

This PR have:

  • New flag(--delete-namespace) for server:delete which allows users to delete the namespace after remove Che resources from cluster
  • Remove ConsoleLinks from cluster
  • Remove all oauthClientAuthorizations linked to che instance

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-714
eclipse-che/che#17784

@flacatus
Rework server:delete to remove consoleLinks or namespace
34ad61f 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus flacatus changed the title Rework server:delete to remove consoleLinks or namespace feat: Rework server:delete to remove consoleLinks or namespace Sep 3, 2020
@flacatus
Fix descriptions
0af0584 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus flacatus changed the title feat: Rework server:delete to remove consoleLinks or namespace feat: Rework server:delete to remove consoleLinks, namespace or openshift consoleLink Sep 3, 2020
@tolusha tolusha mentioned this pull request Sep 3, 2020
Closed
58 tasks
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/commands/server/delete.ts Outdated Show resolved Hide resolved
@flacatus
Fixes
7b32890 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
mmorhun
mmorhun reviewed Sep 3, 2020
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
@flacatus
Fixes
6f190be 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/tasks/che.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 3, 2020
View reviewed changes
src/tasks/che.ts Outdated Show resolved Hide resolved
@flacatus
Fixes
dce37ab 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@tolusha tolusha mentioned this pull request Sep 4, 2020
Closed
1 task
tolusha
tolusha reviewed Sep 4, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 4, 2020
View reviewed changes
src/tasks/che.ts Outdated Show resolved Hide resolved
@flacatus flacatus changed the title feat: Rework server:delete to remove consoleLinks, namespace or openshift consoleLink feat: Rework server:delete to remove consoleLinks, namespace or openshift oauthAuthorizations Sep 4, 2020
tolusha
tolusha reviewed Sep 4, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
tolusha
tolusha reviewed Sep 4, 2020
View reviewed changes
src/api/kube.ts Outdated Show resolved Hide resolved
@flacatus
Fix oauthClientAuthorization
b34a334 
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Collaborator Author

flacatus commented Sep 4, 2020

I've finished to test new changes in minikube and openshift and seems everything is correct:

Openshift:

  1. Install Eclipse Che with OAuth + login into Eclipse Che [I create 2 users to create oauthAuthorizations]
  2. server:delete, check if any resources exist(consoleLink, oauthAuths...)... work fine
  3. Execute again and check if fix Angel issue [Object object] (Executing chectl server:delete twice gives Error: [object Object] eclipse-che/che#17784).. Fixed
  4. Install Eclipse Che without OAuth
  5. server:delete to check if resources are removed... Work fine.

Minikube:
Basically I did the same steps like for openshift but without oauth and seems everything works fine

@flacatus flacatus merged commit 7f092fd into che-incubator:master Sep 4, 2020
@che-bot che-bot added this to the 7.19 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@mmorhun mmorhun mmorhun approved these changes

@l0rd l0rd Awaiting requested review from l0rd

Assignees

@tolusha tolusha

@AndrienkoAleksandr AndrienkoAleksandr

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
7.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flacatus @tolusha @AndrienkoAleksandr @mmorhun @openshift-ci-robot @che-bot