Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit flag type annotations per microsoft/TypeScript#29221 to fix downstream build #921

Merged

Conversation

nickboldt
Copy link
Collaborator

add explicit flag type annotations per microsoft/TypeScript#29221 to fix downstream build

Change-Id: I9eee44451b2ed41382cda9a446c47fc5c8f39e33
Signed-off-by: nickboldt nboldt@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…to fix downstream build

Change-Id: I9eee44451b2ed41382cda9a446c47fc5c8f39e33
Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt nickboldt force-pushed the explicit-flag-annotations_master branch from 8b2d663 to a460592 Compare October 11, 2020 19:10
@nickboldt nickboldt changed the title add explicit flag type annotations per... fix: add explicit flag type annotations per microsoft/TypeScript#29221 to fix downstream build Oct 11, 2020
@tolusha
Copy link
Collaborator

tolusha commented Oct 12, 2020

/retest

@tolusha tolusha merged commit a9bbea6 into che-incubator:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants