Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use CR patch file to update Che. #923

Merged
merged 13 commits into from
Oct 21, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Oct 12, 2020

What does this PR do?

Use CR patch file to update Che.

Screenshot/screencast of this PR

Screenshot from 2020-10-12 14-30-22

What issues does this PR fix or reference?

eclipse-che/che#14974

How to test this PR?

Create CR patch file with such content for example:

spec:
  server:
    cheDebug: 'true'

First way(Use operator installer)

  1. Install Che using operator:
$ ./bin/run  server:start -n che -p openshift -m -a operator
  1. Update Che using CR patch file:
$ ./bin/run  server:update -n che -p openshift --che-operator-cr-patch-yaml=/path/to/patch/file.yaml

Second way(Use Olm installer)

  1. Install Che using Olm(default installer for Openshift platform):
$ ./bin/run  server:start -n che -p openshift -m
  1. Update Che using CR patch file:
$ ./bin/run  server:update -n che -p openshift --che-operator-cr-patch-yaml=/path/to/patch/file.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@AndrienkoAleksandr AndrienkoAleksandr changed the title Use CR patch file to update Che. feat: Use CR patch file to update Che. Oct 12, 2020
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/api/kube.ts Outdated Show resolved Hide resolved
src/common-flags.ts Outdated Show resolved Hide resolved
src/tasks/installers/common-tasks.ts Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@flacatus
Copy link
Collaborator

/retest

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants