fix: Use Olm CR sample from CSV #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
flacatus,
l0rd,
mmorhun and
tolusha
as code owners
AndrienkoAleksandr
changed the title
50 tasks
tolusha
reviewed
Oct 15, 2020
tolusha
reviewed
Oct 15, 2020
|
/retest |
mmorhun
approved these changes
Oct 20, 2020
AndrienkoAleksandr
force-pushed
the
useOlmCRSample
branch
from
0d4880d
to
995bf7d
Compare
AndrienkoAleksandr
force-pushed
the
useOlmCRSample
branch
from
995bf7d
to
2cb46eb
Compare
AndrienkoAleksandr
force-pushed
the
useOlmCRSample
branch
2 times, most recently
from
2885d5f
to
1b60c40
Compare
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
force-pushed
the
useOlmCRSample
branch
from
1b60c40
to
f6d88d3
Compare
|
rebased |
tolusha
reviewed
Oct 22, 2020
tolusha
reviewed
Oct 22, 2020
tolusha
approved these changes
Oct 22, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
CI is finally green... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use Olm CR sample from CSV
What issues does this PR fix or reference?
None. Code enhancement.
How to test this PR?
Install Che on the Openshift platform:
Take a look on the CR:
Check Che using url.
And also make sure that operator installer still works too:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com