Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Store cheCA.crt file into tmp directory #931

Merged
merged 1 commit into from
Oct 21, 2020
Merged

feat: Store cheCA.crt file into tmp directory #931

merged 1 commit into from
Oct 21, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Oct 15, 2020 •
edited
Loading

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Links exported certificate to a platform

Screenshot/screencast of this PR

./run cacert:export
› Current Kubernetes context: 'minikube'
Eclipse Che self-signed CA certificate is exported to /tmp/cheCA.crt

How to test this PR?

  1. build the project
  2. Deploy Eclipse Che
  3. bin/run cacert:export

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from mmorhun October 15, 2020 13:15
@tolusha tolusha changed the title Link chectl certificate to install platform feat: Link Eclipse Che certificate to install platform Oct 15, 2020
@tolusha tolusha mentioned this pull request Oct 15, 2020
Closed
50 tasks
@tolusha tolusha changed the title feat: Link Eclipse Che certificate to install platform feat: Store cheCA.crt file into tmp directory Oct 19, 2020
@tolusha
Store cheCA.crt into tmp director
bc2c97a 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented Oct 20, 2020

/retest

1 similar comment
@tolusha
Copy link
Collaborator Author

tolusha commented Oct 20, 2020

/retest

mmorhun
mmorhun approved these changes Oct 20, 2020
View reviewed changes
src/api/che.ts
async saveCheCaCert(cheCaCert: string, destination?: string): Promise<string> {
const cheCaCertFile = this.getTargetFile(destination)
fs.writeFileSync(cheCaCertFile, cheCaCert)
return cheCaCertFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheCaCertFilePath

@mmorhun mmorhun removed their assignment Oct 20, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit b21f570 into master Oct 21, 2020
@tolusha tolusha deleted the che-17920 branch October 21, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@mmorhun mmorhun mmorhun approved these changes

@flacatus flacatus flacatus approved these changes

@l0rd l0rd Awaiting requested review from l0rd

Assignees

@AndrienkoAleksandr AndrienkoAleksandr

@flacatus flacatus

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tolusha @openshift-ci-robot @AndrienkoAleksandr @mmorhun @flacatus