Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix appearing server start deprectation note #943

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

Fix appearing serverstart command deprectation note

What issues does this PR fix or reference?

Little quick fix

How to test this PR?

Run:

./bin/run server:deploy -n che -p openshift -m

Message:

Warning: 'server:start' command is deprecated. Use 'server:deploy'

should not appear.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title Fix appearing server start deprectation note fix: Fix appearing server start deprectation note Oct 21, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Collaborator

tolusha commented Oct 22, 2020

@AndrienkoAleksandr
Please, back port this to 7.20.x as well.

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

@AndrienkoAleksandr AndrienkoAleksandr merged commit 1f2cc97 into master Oct 22, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the fixAppearingServerStartDepractationNote branch October 22, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants