chore: Release 1.0.0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Click here to review and test in web IDE: |
|
I think about some release notes to mention that it won't be possible to upgrade Kubernetes Image Puller from v0.1.0 to v1.0.0 via OLM. Re-installation will be required. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Click here to review and test in web IDE: |
ibuziuk
reviewed
May 10, 2022
Comment on lines
+8
to
12
| #configMapGenerator: | ||
| #- files: | ||
| # - controller_manager_config.yaml | ||
| # name: manager-config | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 |
There was a problem hiding this comment.
@tolusha is it expected to be commented out?
There was a problem hiding this comment.
Basically yes,
kustomization.yaml files contain such commented lines, for instance:
That's ok to have them there.
ibuziuk
reviewed
May 10, 2022
| @@ -53,7 +67,7 @@ spec: | |||
| name: Ilya Buziuk | |||
| - email: tgeorge@redhat.com | |||
There was a problem hiding this comment.
@tolusha could you please add yourself to the maintainer list and drop Tom George?
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Click here to review and test in web IDE: |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Click here to review and test in web IDE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko abazko@redhat.com
Release a new kubernetes image puller operator:
config-manager.yamlfrom the bundle (it is not used by operator)128Mistablestablewhen building olm catalogCatalog image to test:
docker.io/abazko/kip-catalog:test