Async handlers not working

[andrewvc]

The following code never prints out the statement

require 'manticore'
client = Manticore::Client.new
x = client.async.post("http://andrewvc.com") do |request|
  request.on_complete { puts "COMPLETE" }
end

Is .async broken at the moment?

[cheald]

Oh, I think the doc may be out of date here. At one point, I switched the interface for async to basically be exactly the same as sync, just with the .async proxy.

When you pass a block to Client#post, it should becomes an implicit on_success block. If the request is not async, it causes the request to be evaluated immediately. Otherwise, it gets pushed into the async queue. They'll get flushed with you call Client#execute!.

This works as expected:

client = Manticore::Client.new
client.async.post("http://example.org")
  .on_success {|resp| p [:on_success, resp] }
  .on_complete { puts "Complete 1" }

client.async.post("http://example.org")
  .on_success {|resp| p [:on_success, resp] }
  .on_complete { puts "Complete 2" }

client.execute!

I'm going to wire up some tests to see what's going on, and will test the doc'd behavior and fix the doc if necessary.

[cheald]

I've updated the doc to reflect that the old "pass a block to which the request is yielded" syntax is no longer valid. Additionally, I added some specs to response_spec which explicitly test the behavior of each of the callback handlers.

Your corrected example should be:

require 'manticore'
client = Manticore::Client.new
x = client.async.post("http://andrewvc.com")
      .on_complete { puts "COMPLETE" }
client.execute!