Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: More feedback on script enable failures #1009

Open
Symbai opened this issue Nov 28, 2019 · 3 comments
Open

Minor: More feedback on script enable failures #1009

Symbai opened this issue Nov 28, 2019 · 3 comments

Comments

@Symbai
Copy link
Contributor

Symbai commented Nov 28, 2019

Scanning without attached to a process throws an error. Maybe doing the same when trying to enable a script without attached to a process would be a nice idea? Currently it just does nothing at all.

Also trying to enable a script where the AOB fails just do nothing. Would be great to have a feedback about what exactly failed, especially if there are multiple AOBs and only one has failed.

@mgrinzPlayer
Copy link
Contributor

mgrinzPlayer commented Nov 29, 2019

If script fails to activate you can right click it, error message will be at the top.

@Symbai
Copy link
Contributor Author

Symbai commented Nov 29, 2019

Why not showing a messagebox? Even for consumers this might be interesting to know why it doesn't work?! Right click could be used for showing more detailed errors but not for showing a general error.

@mgrinzPlayer
Copy link
Contributor

mgrinzPlayer commented Nov 29, 2019

If something doesn't work user should either:

  • check that process is opened, not opened process is signaled with flashing icon
  • open the script and then click OK, CE will show a message
  • or right click the script to get the same message

Edit:
CT creator can add this to the main script:

{$Lua}
memrec.OnActivate = function(mr,before,state)
    if before then return true end
    if not state then showMessage(mr.LastAAExecutionFailedReason) end
  end
{$Asm}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants