Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-ode78-ode89 #2398

Merged
merged 6 commits into from
Aug 3, 2023
Merged

feature-ode78-ode89 #2398

merged 6 commits into from
Aug 3, 2023

Conversation

nickhale
Copy link
Contributor

@nickhale nickhale commented Oct 7, 2021

Implement ode78 and ode89 wrappers (for the new ode solvers in R2021b).

This is the error that will be thrown is a user has an older MATLAB version (which seems sensible)

Unrecognized function or variable 'ode89'.
Error in chebfun/constructODEsol (line 38)
    sol = solver(odefun, tspan, uinit, varargin{:});
Error in chebfun.ode89 (line 29)
[varargout{1:nargout}] = chebfun.constructODEsol(@ode89, varargin{:});
Error in test_ivp (line 34)
[t, y] = chebfun.ode89(@vdp1, [0, 20], [2 ; 0], opts); % CHEBFUN solution 

@aaustin141
Copy link
Contributor

Does anybody object to me merging this? All related tests pass, and I know someone interested in this functionality.

@trefethen
Copy link
Contributor

I'm ok with it if you're confident.

@aaustin141 aaustin141 merged commit ce4abe7 into master Aug 3, 2023
0 of 2 checks passed
@aaustin141
Copy link
Contributor

The only tests I saw fail were these:

   chebfun2/test_roots.m
   linop/test_eigsRayleigh.m
   misc/test_gpr.m

The failure in chebfun2/test_roots.m occurs on test 25, which already has an extremely loose tolerance. The failure in linop/test_eigsRayleigh.m occurs on test 2. The tolerance would need to be loosened by a factor of about 100 to pass for me, which is a little much, but in an absolute sense, the accuracy is still pretty good (around 1e-9). The failure in misc/test_gpr.m is pretty catastrophic: I only get an error of 1e-4 on test 10, while the tolerance is 1e-10. But it's clear this pull request can't have caused that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants