Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change prz to remove zero weights to avoid spurious poles #2437

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

nakatsukasayuji
Copy link
Contributor

The prz.m code, when the input vector wj contains an entry that is exactly 0, outputs a spurious pole that is not a pole of the rational function. This is because the generalized eigenvalue problem that the prz code is based on proceeds by multiplying the node polynomial to each partial fraction in the barycentric form, then finding the roots of that polynomial. This fix remedies this issue.

@trefethen trefethen merged commit 2e1cc63 into master Apr 16, 2023
1 check passed
@trefethen
Copy link
Contributor

Thanks @nakatsukasayuji. Looks good.

@trefethen trefethen deleted the prz-remove-zeroweights branch June 1, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants