change prz to remove zero weights to avoid spurious poles #2437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prz.m code, when the input vector wj contains an entry that is exactly 0, outputs a spurious pole that is not a pole of the rational function. This is because the generalized eigenvalue problem that the prz code is based on proceeds by multiplying the node polynomial to each partial fraction in the barycentric form, then finding the roots of that polynomial. This fix remedies this issue.