Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: controlled input value warning #295

Closed
wants to merge 2 commits into from
Closed

fix: controlled input value warning #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ab9b8
fix: controlled input value warning
rortan134 Jul 26, 2022
b082cd2
fix: ignore hydratation warning
rortan134 Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions components/checkout/common/AddressForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,13 @@ export default class AddressForm extends Component {
<p className="mb-1 font-size-caption font-color-light">
Full name*
</p>
<input required name={`${type}[name]`} autoComplete="name" value={name} className="rounded-0 w-100" />
<input
required
name={`${type}[name]`}
autoComplete="name"
value={name}
onChange={(e) => this.setState({ name: e.target.value })}
className="rounded-0 w-100" />
</label>
</div>
</div>
Expand Down Expand Up @@ -91,7 +97,13 @@ export default class AddressForm extends Component {
<div className="col-12 col-sm-6 mb-3">
<label className="w-100">
<p className="mb-1 font-size-caption font-color-light">City*</p>
<input required name={`${type}[town_city]`} autoComplete="address-level2" value={townCity} className="rounded-0 w-100" />
<input
required
name={`${type}[town_city]`}
autoComplete="address-level2"
value={townCity}
onChange={(e) => this.setState({ townCity: e.target.value })}
className="rounded-0 w-100" />
</label>
</div>
</div>
Expand All @@ -106,6 +118,7 @@ export default class AddressForm extends Component {
autoComplete="street-address"
name={`${type}[street]`}
value={street}
onChange={(e) => this.setState({ street: e.target.value })}
className="rounded-0 w-100"
placeholder="House number, steet address, etc."
/>
Expand All @@ -119,6 +132,7 @@ export default class AddressForm extends Component {
<input
name={`${type}[street_2]`}
value={street2}
onChange={(e) => this.setState({ street2: e.target.value })}
className="rounded-0 w-100"
placeholder="Apartment, suite number, etc."
/>
Expand Down Expand Up @@ -157,6 +171,7 @@ export default class AddressForm extends Component {
autoComplete="postal-code"
name={`${type}[postal_zip_code]`}
value={postalZipCode}
onChange={(e) => this.setState({ postalZipCode: e.target.value })}
className="rounded-0 w-100"
/>
</label>
Expand Down
4 changes: 4 additions & 0 deletions components/checkout/common/PaymentDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default class PaymentDetails extends Component {
name="cardNumber"
pattern="[0-9. ]+"
value={cardNumber}
onChange={(e) => this.setState({ cardNumber: e.target.value})}
maxLength="16"
className="rounded-0 w-100"
/>
Expand All @@ -62,6 +63,7 @@ export default class PaymentDetails extends Component {
<input
name="cvc"
value={cvc}
onChange={(e) => this.setState({ cvc: e.target.value})}
maxLength="3"
type="number"
className="rounded-0 w-100"
Expand All @@ -77,6 +79,7 @@ export default class PaymentDetails extends Component {
name="expMonth"
type="number"
value={expMonth}
onChange={(e) => this.setState({ expMonth: e.target.value})}
className="rounded-0 w-100"
placeholder="MM"
/>
Expand All @@ -91,6 +94,7 @@ export default class PaymentDetails extends Component {
type="number"
name="expYear"
value={expYear}
onChange={(e) => this.setState({ expYear: e.target.value})}
className="rounded-0 w-100"
placeholder="YY"
/>
Expand Down
2 changes: 1 addition & 1 deletion components/common/Header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class Header extends Component {
</a>
</Link>
</div>
<div className="d-flex">
<div className="d-flex" suppressHydrationWarning={true}>
{ process.browser && this.renderLoginLogout() }
<div
className="position-relative cursor-pointer"
Expand Down
1 change: 1 addition & 0 deletions components/common/atoms/Dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class Dropdown extends Component {
required={this.props.required || undefined}
disabled={this.props.disabled || undefined}
value={this.props.value}
onChange={(e) => this.setState({value: e.target.value})}
className="position-absolute top-0 right-0 bottom-0 left-0 opacity-0 pointer w-100">
<option value="" disabled>
{ this.props.disabledOptionText || 'Select an option' }
Expand Down
24 changes: 21 additions & 3 deletions pages/checkout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,15 +573,27 @@ class CheckoutPage extends Component {
<p className="mb-1 font-size-caption font-color-light">
First name*
</p>
<input required name="customer[first_name]" autoComplete="given-name" value={this.state['customer[first_name]']} className="rounded-0 w-100" />
<input
required
name="customer[first_name]"
autoComplete="given-name"
value={this.state['customer[first_name]']}
onChange={(e) => this.setState({['customer[first_name]']: e.target.value})}
className="rounded-0 w-100" />
</label>
</div>
<div className="col-12 col-sm-6 mb-3">
<label className="w-100">
<p className="mb-1 font-size-caption font-color-light">
Last name*
</p>
<input required name="customer[last_name]" autoComplete="family-name" value={this.state['customer[last_name]']} className="rounded-0 w-100" />
<input
required
name="customer[last_name]"
autoComplete="family-name"
value={this.state['customer[last_name]']}
onChange={(e) => this.setState({['customer[last_name]']: e.target.value})}
className="rounded-0 w-100" />
</label>
</div>
</div>
Expand All @@ -595,6 +607,7 @@ class CheckoutPage extends Component {
name="customer[phone]"
autoComplete="tel"
value={this.state['customer[phone]']}
onChange={(e) => this.setState({['customer[phone]']: e.target.value})}
className="rounded-0 w-100"
/>
</label>
Expand All @@ -609,6 +622,7 @@ class CheckoutPage extends Component {
name="customer[email]"
autoComplete="email"
value={this.state['customer[email]']}
onChange={(e) => this.setState({['customer[email]']: e.target.value})}
className="rounded-0 w-100"
/>
</label>
Expand Down Expand Up @@ -674,7 +688,11 @@ class CheckoutPage extends Component {
<p className="mb-1 font-size-caption font-color-light">
Order notes (optional)
</p>
<textarea name="orderNotes" value={this.state.orderNotes} className="rounded-0 w-100" />
<textarea
name="orderNotes"
value={this.state.orderNotes}
onChange={(e) => this.setState({ orderNotes: e.target.value})}
className="rounded-0 w-100" />
</label>
</div>

Expand Down