Switch location #82
Merged
Switch location #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeevan Surendran <jvns67@gmail.com>
jeevansurendran
commented
Mar 5, 2020
Signed-off-by: Jeevan Surendran <jvns67@gmail.com>
Signed-off-by: Jeevan Surendran <jvns67@gmail.com>
Signed-off-by: Jeevan Surendran <jvns67@gmail.com>
shivanshs9
requested changes
Mar 9, 2020
app/src/main/java/com/checkin/app/checkin/home/fragments/UserLocationFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/home/viewmodels/UserLocationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/home/viewmodels/UserLocationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/menu/viewmodels/BaseMenuViewModel.kt
Outdated
Show resolved
Hide resolved
| liveViewModel.clearCartData.observe(this, Observer { }) | ||
|
|
||
| mViewModel.setCityId(getCityId()) |
There was a problem hiding this comment.
You're calling fetchNearbyRestaurants twice because of setCityId call. No need to waste mobile data twice in getting the same data.
app/src/main/java/com/checkin/app/checkin/data/network/WebApiService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/Shop/ShopRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/home/epoxy/CityLocationModelHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/home/epoxy/CurrentLocationModelHolder.kt
Outdated
Show resolved
Hide resolved
| cityListener { _ -> | ||
| val preferences = requireActivity().getSharedPreferences(Constants.LOCATION_CITY_FILE, Context.MODE_PRIVATE) | ||
| with(preferences.edit()) { | ||
| putInt(Constants.LOCATION_CITY_ID, model.id) |
There was a problem hiding this comment.
The coding pattern is really wrong here.
You're using a model variable bound to the one in loop. It's better to use the interface I mentioned above and declare the parameters for city data
There was a problem hiding this comment.
You still didn't change that. I already mentioned to properly use interface and use the parameters in the interface
|
Current location shouldn't be shown when typed |
jeevansurendran
force-pushed
the
switch-location
branch
from
04b8d64
to
60793c3
Compare
shivanshs9
requested changes
Mar 14, 2020
| cityListener { _ -> | ||
| val preferences = requireActivity().getSharedPreferences(Constants.LOCATION_CITY_FILE, Context.MODE_PRIVATE) | ||
| with(preferences.edit()) { | ||
| putInt(Constants.LOCATION_CITY_ID, model.id) |
There was a problem hiding this comment.
You still didn't change that. I already mentioned to properly use interface and use the parameters in the interface
app/src/main/java/com/checkin/app/checkin/menu/listeners/LocationSelectedListener.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/menu/listeners/LocationSelectedListener.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/checkin/app/checkin/home/epoxy/CityLocationModelHolder.kt
Outdated
Show resolved
Hide resolved
| val homeViewModel: HomeViewModel by activityViewModels() | ||
| @BindView(R.id.et_user_location) | ||
| internal lateinit var etUserLocation: EditText | ||
|
|
There was a problem hiding this comment.
Don't waste lines in between View fields... Fix that in all the files (like holder)
|
|
||
| class UserLocationFragment : BaseFragment() { | ||
| override val rootLayout = R.layout.fragment_user_location_switch | ||
| val viewModel: UserLocationViewModel by viewModels() |
There was a problem hiding this comment.
Declare these variables after all the UI views are declared. Always keep rootLayout at the top, though.
app/src/main/java/com/checkin/app/checkin/home/epoxy/CityLocationModelHolder.kt
Outdated
Show resolved
Hide resolved
|
|
||
| @BindView(R.id.tv_user_location_state) | ||
| internal lateinit var tvStateLocation: TextView | ||
|
|
There was a problem hiding this comment.
Lots of needless blank lines here too. Always try and keep your code compact.
app/src/main/java/com/checkin/app/checkin/home/fragments/UserLocationFragment.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeevan Surendran <jvns67@gmail.com>
shivanshs9
added a commit
that referenced
this pull request
Mar 16, 2020
- Added swipe refresh in closed sessions listing - Cleaned Util logic to format duration - Fixed bug in UserLocationFragment not attached when selecting any option - Used default SharedPreferences for location too - Used proper way to use appbar by mentioning theme in manifest - Used the core manifest for new screens Signed-off-by: Shivansh Saini <shivanshs9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything other than the main page where the location needs to be shown is implemented i guess.