Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typescript eslint parser to support typescript 5 [gh-848] #857

Merged
merged 1 commit into from Sep 25, 2023

Conversation

umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented Sep 22, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Upgrade typescript parser to the latest version, 6.x, to support typescript 5.2 and above

Resolves #848 with the next release

Copy link
Collaborator

@clample clample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the new typescript-estree library dropped support for some old TS versions. I think that we should keep track to add it to the release notes.

@umutuzgur
Copy link
Member Author

@clample definitely. I wanna make a test release today and post it in the issue so people can give it a try

@clample
Copy link
Collaborator

clample commented Sep 22, 2023

@clample definitely. I wanna make a test release today and post it in the issue so people can give it a try

Sounds good 👍

@umutuzgur umutuzgur added the build Issue regarding building and packaging label Sep 22, 2023
@github-actions
Copy link

🎉 Experimental release successfully published on npm

npm install checkly@0.0.0-pr.857.4cd41ea

@umutuzgur umutuzgur merged commit 741d640 into main Sep 25, 2023
4 checks passed
@umutuzgur umutuzgur deleted the umutuzgur/gh-848/typescript-eslint-upgrade branch September 25, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue regarding building and packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Can’t use latest TypeScript
2 participants