Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates runtimes in examples and defaults to 2023.09 #897

Merged
merged 6 commits into from Nov 30, 2023
Merged

feat: updates runtimes in examples and defaults to 2023.09 #897

merged 6 commits into from Nov 30, 2023

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Nov 29, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Updates the examples to the latest runtime.

ferrandiaz
ferrandiaz previously approved these changes Nov 30, 2023
View reviewed changes
ferrandiaz
ferrandiaz reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ferrandiaz ferrandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failing, on the deploy.spec.ts I'm unsure how your changes might have affected that particular test

@tnolet
Copy link
Member Author

tnolet commented Nov 30, 2023

There is a test failing, on the deploy.spec.ts I'm unsure how your changes might have affected that particular test

that's super weird. I'm just rerunning it

@tnolet tnolet changed the title feat: updates runtimes to 2023.09 feat: updates runtimes in examples and defaults to 2023.09 Nov 30, 2023
@tnolet
Copy link
Member Author

tnolet commented Nov 30, 2023

should fix: #898

ferrandiaz
ferrandiaz approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ferrandiaz ferrandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnolet tnolet merged commit 01faf71 into main Nov 30, 2023
3 checks passed
@tnolet tnolet deleted the tnolet/bump-runtime-in-examples branch November 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrandiaz ferrandiaz ferrandiaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnolet @ferrandiaz