Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tnolet/update examples and readmes #904

Merged
merged 5 commits into from Dec 14, 2023
Merged

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Dec 7, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • removes the unneeded services/ dir in examples.
  • renames some examples for clarity.,
  • updates the readme with fixes and some extra info.
  • fixes small typo in create package.

Resolves #[issue-number]

New Dependency Submission

ferrandiaz
ferrandiaz previously approved these changes Dec 13, 2023
@tnolet
Copy link
Member Author

tnolet commented Dec 14, 2023

@ferrandiaz FINALLY fixed the test. Can you rubberstamp it again?

@tnolet tnolet merged commit 48901af into main Dec 14, 2023
3 checks passed
@tnolet tnolet deleted the tnolet/update-examples-and-readmes branch December 14, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants