Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing options on playwright config support #908

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: add missing options on playwright config support #908

merged 1 commit into from
Dec 21, 2023

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add support for accuracy, toHaveScreenshot and toMatchSnapshot on playwright config

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #18667: Add toHaveScreenshot() and toMatchSnapshot() setting to PWT config expect section.

umutuzgur
umutuzgur previously approved these changes Dec 21, 2023
View reviewed changes
@ferrandiaz ferrandiaz force-pushed the ferran/sc-18667/extend-pwtconfig branch from 497a039 to 7580a5f Compare December 21, 2023 13:44
@ferrandiaz ferrandiaz merged commit 98a2bf5 into main Dec 21, 2023
3 checks passed
@ferrandiaz ferrandiaz deleted the ferran/sc-18667/extend-pwtconfig branch December 21, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umutuzgur umutuzgur umutuzgur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferrandiaz @umutuzgur