Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support arrays of glob patterns #913

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Dec 22, 2023

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • allows string[] for all glob patterns.
  • adds tests to showcase that all heavy lifting (deduplications etc.) is done by the underlying glob library

How to test this?

For instance, you can just add arrays to the checkly.config.ts i.e.

    checkMatch: ['**/__checks__/**/*.check.ts', '**/more-checks/**/*.check.ts'],
    browserChecks: {
      testMatch: ['**/__checks__/**/*.spec.ts', 'other-tests/**/*.spec.ts'],

Even with nested folders, the glob library will return a set of paths and checks that matches the expectations, e.g. no duplicates in overlapping glob definitions.

Resolves #[911]

Copy link
Collaborator

@clample clample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tnolet tnolet merged commit e80c498 into main Dec 27, 2023
3 checks passed
@tnolet tnolet deleted the 911-story-support-an-array-of-glob-patterns-for-all-checkmatch-and-testmatch-properties branch December 27, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story: support an array of glob patterns for all checkMatch and testMatch properties
3 participants