Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print session url on all reporters #923

Merged
merged 1 commit into from Jan 17, 2024
Merged

fix: print session url on all reporters #923

merged 1 commit into from Jan 17, 2024

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Not all the reporters were printing the test session url

Resolves #918

umutuzgur
umutuzgur approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@umutuzgur umutuzgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiroushi kiroushi added the build Issue regarding building and packaging label Jan 17, 2024
@github-actions GitHub Actions
Copy link

🎉 Experimental release successfully published on npm

npm install checkly@0.0.0-pr.923.5d298df

@ferrandiaz ferrandiaz merged commit 5cd5fc1 into main Jan 17, 2024
4 checks passed
@ferrandiaz ferrandiaz deleted the ferran/test-session-url branch January 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umutuzgur umutuzgur umutuzgur approved these changes

@clample clample clample approved these changes

Assignees
No one assigned
Labels
build Issue regarding building and packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: include test session URL in ci output
4 participants
@ferrandiaz @umutuzgur @clample @kiroushi