feat: move playwright config at check level #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #19039: move playwrightConfig to check level. |
umutuzgur
reviewed
Jan 24, 2024
| import * as fs from 'fs' | ||
| import { PlaywrightConfig } from '../constructs/playwright-config' | ||
|
|
||
| export type CheckConfigDefaults = Pick<CheckProps, 'activated' | 'muted' | 'doubleCheck' |
There was a problem hiding this comment.
I think playwrightConfig should be here, right?
There was a problem hiding this comment.
Playwright config is not part of the CheckProps to avoid setting it on all the checks.
|
🎉 Experimental release successfully published on npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer