-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check examples to the ms docs #1016
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drakirnosslin left some nits and suggestions.
``` | ||
|
||
### Verifying binary payloads | ||
One way to ensure that e.g CDN endpoints are serving images correctly is by verifying its binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drakirnosslin nit: missing dot after the g, e.g.
}) | ||
``` | ||
|
||
If you have suggestions for additional check examples to add here, please do not hesitate to reach out to our [support](mailto:support@checklyhq.com), or join our [Slack community](https://www.checklyhq.com/slack/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drakirnosslin suggestion: we could also ask people to submit a PR, since the repo is public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drakirnosslin LGTM
Affected Components
Pre-Requisites
npm run lint
)Notes for the Reviewer
New Dependency Submission
Screenshots