Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limit to 2.9, use correct units GiB #1029

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Update limit to 2.9, use correct units GiB #1029

merged 1 commit into from
Jun 12, 2024

Conversation

jan-osch
Copy link
Member

@jan-osch jan-osch commented Jun 12, 2024 •
edited
Loading

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

  • Update the specs according to our new EKS limits
  • We are allocating 3000 MiB for browser check pods, and we gracefully fail the check run when it reaches 99% of that limit which is 2.9 GiB
  • Use GiB because we are not selling USB sticks

@jan-osch jan-osch requested a review from tnolet as a code owner June 12, 2024 14:34
@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 2:34pm

@jan-osch jan-osch requested review from benben and pelzerim and removed request for tnolet June 12, 2024 14:34
@jan-osch jan-osch requested a review from tnolet June 12, 2024 14:35
@jan-osch jan-osch merged commit ae96087 into main Jun 12, 2024
6 checks passed
@jan-osch jan-osch deleted the jan/update-memory-limits branch June 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benben benben benben approved these changes

@pelzerim pelzerim Awaiting requested review from pelzerim

@tnolet tnolet Awaiting requested review from tnolet tnolet is a code owner

Assignees

@jan-osch jan-osch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-osch @benben